Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enabling custom labes for event, metrics and logs services #1550

Merged
merged 6 commits into from
Apr 20, 2021
Merged

enabling custom labes for event, metrics and logs services #1550

merged 6 commits into from
Apr 20, 2021

Conversation

mozz-lx
Copy link
Contributor

@mozz-lx mozz-lx commented Apr 12, 2021

Description

Enabled custom labels in fluentd logs, events and metrics services.

Testing performed
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@mozz-lx mozz-lx requested a review from a team April 12, 2021 16:27
@mozz-lx mozz-lx mentioned this pull request Apr 12, 2021
Closed
pmalek-sumo
pmalek-sumo reviewed Apr 14, 2021
View reviewed changes
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally the idea seems nice, 1 minor comment though:

This shouldn't really piggy back on fluentd.podLabels as it's not pods that we attach these labels to here but rather services. Hence I suggest to add new value e.g. fluentd.serviceLabels similar to fluentd.podLabels and use that

@pmalek-sumo
Copy link
Contributor

One more thing actually: please make this a template so that we don't need the if everywhere just in the template 👍

@mozz-lx
Copy link
Contributor Author

mozz-lx commented Apr 19, 2021 •
edited
Loading

One more thing actually: please make this a template so that we don't need the if everywhere just in the template 👍

Hello @pmalek-sumo,

Changed fluentd.podLabels to fluentd.serviceLabels. I'm not familiar with the templates that you mentioned. I'm hopping this can work for now.

Marco.

@pmalek-sumo
Copy link
Contributor

One more thing actually: please make this a template so that we don't need the if everywhere just in the template 👍

Hello @pmalek-sumo,

Changed fluentd.podLabels to fluentd.serviceLabels. I'm not familiar with the templates that you mentioned. I'm hopping this can work for now.

Marco.

Thanks for changing this. I'll merge it and introduce the aforementioned templates.

@pmalek-sumo pmalek-sumo merged commit 4d532a7 into SumoLogic:main Apr 20, 2021
@perk-sumo perk-sumo added this to the v2.2 milestone Jun 7, 2021
@perk-sumo perk-sumo linked an issue Jun 7, 2021 that may be closed by this pull request
add an option to include custom labels for fluentd services #1544
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek-sumo pmalek-sumo pmalek-sumo approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel

@frankreno frankreno Awaiting requested review from frankreno

@kasia-kujawa kasia-kujawa Awaiting requested review from kasia-kujawa

@perk-sumo perk-sumo Awaiting requested review from perk-sumo

@sumo-drosiek sumo-drosiek Awaiting requested review from sumo-drosiek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.

add an option to include custom labels for fluentd services
3 participants
@mozz-lx @pmalek-sumo @perk-sumo